Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 )
Change subject: IMPALA-6714: [DOCS] ORC file format support ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml File docs/topics/impala_orc.xml: http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@93 PS1, Line 93: If you do not have an existing data file to use, begin by creating one in the appropriate format. > OK. This is the same as other formats' docs. Do you think they should all b Yea don't think this is very helpful. Thanks for pointing out this is all over, created IMPALA-7107. http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@152 PS1, Line 152: Enabling Compression for ORC Tables > I think it's reasonable. There're no details examples in the official site You're right. This comes a bit closer: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+ORC#LanguageManualORC-HiveQLSyntax, but still lacks examples. My concern is that this documents Hive behaviour, not Impala (e.g Hive might change the preferred way of altering compression). I don't feel strongly about this, we can cover it in IMPALA-7107 if need be. -- To view, visit http://gerrit.cloudera.org:8080/10525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 Gerrit-Change-Number: 10525 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Balazs Jeszenszky <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 01 Jun 2018 13:13:28 +0000 Gerrit-HasComments: Yes
