Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22804 )
Change subject: IMPALA-13631: (Addendum) Test slow concurrent alters ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22804/1/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/22804/1/tests/metadata/test_ddl.py@501 PS1, Line 501: "catalogd_table_rename_delay:SLEEP@5000" : handle1 = self.execute_query_async_using_client(self.client, alter(1, 3), new_vector) : handle2 = self.execute_query_async_using_client(self.client, alter(2, 4), new_vector) : # Timeouts are set such that the 1st must finish in <10s, and the 2nd <5s after. : assert self.client.wait_for_finished_timeout(handle1, timeout=10 The two renames are not operating over common table, so the only serial execution is happening at catalog_.renameTable(). I think it is better to add assertion that total time spent on these lines is less than 10s? http://gerrit.cloudera.org:8080/#/c/22804/2/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/22804/2/tests/metadata/test_ddl.py@486 PS2, Line 486: def test_alter_table_rename_independent(self, vector, unique_database): Tag it with @pytest.mark.execute_serially nit: Add test doc that says the two renames must happen concurrently. -- To view, visit http://gerrit.cloudera.org:8080/22804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87d077aaa295943a16e6da60a2755dd289f3a132 Gerrit-Change-Number: 22804 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 23 Apr 2025 00:17:48 +0000 Gerrit-HasComments: Yes
