Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22804 )
Change subject: IMPALA-13631: (Addendum) Test slow concurrent alters ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22804/1/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/22804/1/tests/metadata/test_ddl.py@495 PS1, Line 495: # Ensure loading metadata is not a factor in alter execution time. : self.client.execute("refresh {}".format(table_name(1))) We can simply use DESCRIBE so the metadata is also loaded in local-catalog mode coordinator side. REFRESH will evict the cache in local-catalog mode coordinators. http://gerrit.cloudera.org:8080/#/c/22804/1/tests/metadata/test_ddl.py@501 PS1, Line 501: "catalogd_table_rename_delay:SLEEP@5000" : handle1 = self.execute_query_async_using_client(self.client, alter(1, 3), new_vector) : handle2 = self.execute_query_async_using_client(self.client, alter(2, 4), new_vector) : # Timeouts are set such that the 1st must finish in <10s, and the 2nd <5s after. : assert self.client.wait_for_finished_timeout(handle1, timeout=10 > The two renames are not operating over common table, so the only serial exe There are other bottlenecks that we could hit when running this in parallel tests, e.g. slowness in HMS or HDFS/S3 sides. Maybe we can just verify the catalog timeline in profile that "Got catalog version read lock" no longer takes a long time. -- To view, visit http://gerrit.cloudera.org:8080/22804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87d077aaa295943a16e6da60a2755dd289f3a132 Gerrit-Change-Number: 22804 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 23 Apr 2025 01:47:50 +0000 Gerrit-HasComments: Yes
