Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/10486 )
Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/10486/4/be/src/exprs/timezone_db.cc File be/src/exprs/timezone_db.cc: http://gerrit.cloudera.org:8080/#/c/10486/4/be/src/exprs/timezone_db.cc@628 PS4, Line 628: \"SystemV/AST4\",\"AST\",\"Atlantic Standard Time\",\"\",\"\",\"-04:00:00\",\"+00:00:00\",\"\",\"\",\"\",\"\"\n\ : \"SystemV/AST4ADT\",\"AST\",\"Atlantic Standard Time\",\"ADT\",\"Atlantic Daylight Time\",\"-04:00:00\",\"+01:00:00\",\"-1;0;4\",\"+02:00:00\",\"-1;0;10\",\"+02:00:00\"\n\ : \"SystemV/CST6\",\"CST\",\"Central Standard Time\",\"\",\"\",\"-06:00:00\",\"+00:00:00\",\"\",\"\",\"\",\"\"\n\ : \"SystemV/CST6CDT\",\"CST\",\"Central Standard Time\",\"CDT\",\"Central Daylight Time\",\"-06:00:00\",\"+01:00:00\",\"-1;0;4\",\"+02:00:00\",\"-1;0;10\",\"+02:00:00\"\n\ : \"SystemV/EST5\",\"EST\",\"Eastern Standard Time\",\"\",\"\",\"-05:00:00\",\"+00:00:00\",\"\",\"\",\"\",\"\"\n\ : \"SystemV/EST5EDT\",\"EST\",\"Eastern Standard Time\",\"EDT\",\"Eastern Daylight Time\",\"-05:00:00\",\"+01:00:00\",\"-1;0;4\",\"+02:00:00\",\"-1;0;10\",\"+02:00:00\"\n\ : \"SystemV/HST10\",\"HST\",\"Hawaii Standard Time\",\"\",\"\",\"-10:00:00\",\"+00:00:00\",\"\",\"\",\"\",\"\"\n\ : \"SystemV/MST7\",\"MST\",\"Mountain Standard Time\",\"\",\"\",\"-07:00:00\",\"+00:00:00\",\"\",\"\",\"\",\"\"\n\ : \"SystemV/MST7MDT\",\"MST\",\"Mountain Standard Time\",\"MDT\",\"Mountain Daylight Time\",\"-07:00:00\",\"+01:00:00\",\"-1;0;4\",\"+02:00:00\",\"-1;0;10\",\"+02:00:00\"\n\ : \"SystemV/PST8\",\"PST\",\"Pacific Standard Time\",\"\",\"\",\"-08:00:00\",\"+00:00:00\",\"\",\"\",\"\",\"\"\n\ : \"SystemV/PST8PDT\",\"PST\",\"Pacific Standard Time\",\"PDT\",\"Pacific Daylight Time\",\"-08:00:00\",\"+01:00:00\",\"-1;0;4\",\"+02:00:00\",\"-1;0;10\",\"+02:00:00\"\n\ : \"SystemV/YST9\",\"AKST\",\"Alaska Standard Time\",\"\",\"\",\"-09:00:00\",\"+00:00:00\",\"\",\"\",\"\",\"\"\n\ : \"SystemV/YST9YDT\",\"AKST\",\"Alaska Standard Time\",\"AKDT\",\"Alaska Daylight Time\",\"-09:00:00\",\"+01:00:00\",\"-1;0;4\",\"+02:00:00\",\"-1;0;10\",\"+02:00:00\"\n\ I think these lines should be removed too. These are old timezones, kept only for legacy reasons. Although the corresponding rules are part of the IANA timezone data, they are commented out, so they won't be compiled by default. http://gerrit.cloudera.org:8080/#/c/10486/4/testdata/data/timezoneverification.csv File testdata/data/timezoneverification.csv: http://gerrit.cloudera.org:8080/#/c/10486/4/testdata/data/timezoneverification.csv@806 PS4, Line 806: SystemV/AST4,2015-06-20 15:00:00,2015-06-20 11:00:00 : SystemV/AST4ADT,2015-06-20 15:00:00,2015-06-20 12:00:00 : SystemV/AST4ADT,2014-12-20 15:00:00,2014-12-20 11:00:00 : SystemV/CST6,2015-06-20 15:00:00,2015-06-20 09:00:00 : SystemV/CST6CDT,2015-06-20 15:00:00,2015-06-20 10:00:00 : SystemV/CST6CDT,2014-12-20 15:00:00,2014-12-20 09:00:00 : SystemV/EST5,2015-06-20 15:00:00,2015-06-20 10:00:00 : SystemV/EST5EDT,2015-06-20 15:00:00,2015-06-20 11:00:00 : SystemV/EST5EDT,2014-12-20 15:00:00,2014-12-20 10:00:00 : SystemV/HST10,2015-06-20 15:00:00,2015-06-20 05:00:00 : SystemV/MST7,2015-06-20 15:00:00,2015-06-20 08:00:00 : SystemV/MST7MDT,2015-06-20 15:00:00,2015-06-20 09:00:00 : SystemV/MST7MDT,2014-12-20 15:00:00,2014-12-20 08:00:00 : SystemV/PST8,2015-06-20 15:00:00,2015-06-20 07:00:00 : SystemV/PST8PDT,2015-06-20 15:00:00,2015-06-20 08:00:00 : SystemV/PST8PDT,2014-12-20 15:00:00,2014-12-20 07:00:00 : SystemV/YST9,2015-06-20 15:00:00,2015-06-20 06:00:00 : SystemV/YST9YDT,2015-06-20 15:00:00,2015-06-20 07:00:00 : SystemV/YST9YDT,2014-12-20 15:00:00,2014-12-20 06:00:00 These should be removed too, see my previous comment. -- To view, visit http://gerrit.cloudera.org:8080/10486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90859398081bae4976af31b09b3121c198b6adac Gerrit-Change-Number: 10486 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Comment-Date: Sat, 02 Jun 2018 07:35:47 +0000 Gerrit-HasComments: Yes
