Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22899 )

Change subject: IMPALA-14072: Fix NPE in Catalogd during rename.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22899/2/tests/custom_cluster/test_concurrent_rename.py
File tests/custom_cluster/test_concurrent_rename.py:

http://gerrit.cloudera.org:8080/#/c/22899/2/tests/custom_cluster/test_concurrent_rename.py@56
PS2, Line 56:       self.execute_query_ignore_exception("invalidate metadata 
{}2".format(name))
> Why would there be an exception from these commands?
I notice that the Database is dropped before ALTER TABLE RENAME complete. That 
only possible to happen if test is wrapping up (cleaning unique_database 
fixture).
That means the test stop prematurely before reaching L60.

The Catalogd logs indicate that this INVALIDATE at L56 result in exception.

I0514 07:25:17.779038 1776497 CatalogServiceCatalog.java:3016] 
c946ded100ff1f2b:dc0d912e00000000] Invalidating table metadata: 
test_rename_drop_aaefe83a.tbl2
I0514 07:25:17.779104 1776494 CatalogServiceCatalog.java:3016] 
0b46c8f9db650ef0:54dff3b200000000] Invalidating table metadata: 
test_rename_drop_aaefe83a.tbl
E0514 07:25:17.780689 1776497 JniUtil.java:184] 
c946ded100ff1f2b:dc0d912e00000000] Error in INVALIDATE TABLE 
test_rename_drop_aaefe83a.tbl2 issued by jenkins. Time spent: 3ms
I0514 07:25:17.781091 1776497 jni-util.cc:321] 
c946ded100ff1f2b:dc0d912e00000000] 
org.apache.impala.catalog.TableNotFoundException: Table not found: 
test_rename_drop_aaefe83a.tbl2
        at 
org.apache.impala.service.CatalogOpExecutor.execResetMetadataImpl(CatalogOpExecutor.java:7198)
        at 
org.apache.impala.service.CatalogOpExecutor.execResetMetadata(CatalogOpExecutor.java:7068)
        at 
org.apache.impala.service.JniCatalog.lambda$resetMetadata$4(JniCatalog.java:326)
        at 
org.apache.impala.service.JniCatalogOp.lambda$execAndSerialize$1(JniCatalogOp.java:90)
        at org.apache.impala.service.JniCatalogOp.execOp(JniCatalogOp.java:58)
        at 
org.apache.impala.service.JniCatalogOp.execAndSerialize(JniCatalogOp.java:89)
        at 
org.apache.impala.service.JniCatalogOp.execAndSerialize(JniCatalogOp.java:100)
        at 
org.apache.impala.service.JniCatalog.execAndSerialize(JniCatalog.java:242)
        at 
org.apache.impala.service.JniCatalog.execAndSerialize(JniCatalog.java:256)
        at 
org.apache.impala.service.JniCatalog.resetMetadata(JniCatalog.java:325)

So I assume the exception is propagated to test client as 
ImpalaBeeswaxException and stop the test prematurely.



--
To view, visit http://gerrit.cloudera.org:8080/22899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a421a71cf3703290645e85180de8e9d5e86368a
Gerrit-Change-Number: 22899
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Wed, 14 May 2025 22:03:48 +0000
Gerrit-HasComments: Yes

Reply via email to