Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22899 )
Change subject: IMPALA-14072: Fix NPE in Catalogd during rename. ...................................................................... IMPALA-14072: Fix NPE in Catalogd during rename. test_rename_drop fail with NPE after IMPALA-14042. This is because CatalogServiceCatalog.renameTable() return null for not finding the database of oldTableName. This patch change renameTable() to return Pair.create(null, null) for that scenario. Refactor test_rename_drop slightly to ensure that invalidating the renamed table and dropping it are successful. Testing: - Add checkNotNull precondition in CatalogOpExecutor.alterTableOrViewRename() - Increase catalogd_table_rename_delay delay to 6s to ensure that DROP query happen in Catalogd before renameTable() called. Manually observed that No NPE is shown anymore. Change-Id: I7a421a71cf3703290645e85180de8e9d5e86368a Reviewed-on: http://gerrit.cloudera.org:8080/22899 Reviewed-by: Quanlong Huang <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M tests/custom_cluster/test_concurrent_rename.py 3 files changed, 22 insertions(+), 5 deletions(-) Approvals: Quanlong Huang: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/22899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7a421a71cf3703290645e85180de8e9d5e86368a Gerrit-Change-Number: 22899 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
