Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 )
Change subject: IMPALA-7110. Fix some warnings from error-prone ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10583/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10583/1//COMMIT_MSG@21 PS1, Line 21: I elected not to enable error-prone in the maven settings since it > It's likely posssibly to use Maven profiles to make this an optional flag. I'll give this a try, though usually when I attempt to do this kind of thing I end up just banging my head against my desk in frustration. http://gerrit.cloudera.org:8080/#/c/10583/1/fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java File fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java: http://gerrit.cloudera.org:8080/#/c/10583/1/fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java@85 PS1, Line 85: argTypes > nit: Should we update this too? interesting, wonder why it didn't catch this one. Will do. -- To view, visit http://gerrit.cloudera.org:8080/10583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9bfadecb5b92bba4fc7921a6f87f249ed90e771 Gerrit-Change-Number: 10583 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 05 Jun 2018 17:55:14 +0000 Gerrit-HasComments: Yes
