Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 )
Change subject: IMPALA-7110. Fix errors from error-prone ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Phil, can you +2 this, I'm not too familiar with mvn profiles, rest of it lgtm. http://gerrit.cloudera.org:8080/#/c/10583/1/fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java File fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java: http://gerrit.cloudera.org:8080/#/c/10583/1/fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java@85 PS1, Line 85: argTypes > argTypes is a List, so the built-in toString actually works. My fix down be ah, nice catch. -- To view, visit http://gerrit.cloudera.org:8080/10583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9bfadecb5b92bba4fc7921a6f87f249ed90e771 Gerrit-Change-Number: 10583 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 05 Jun 2018 22:11:57 +0000 Gerrit-HasComments: Yes
