Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22901 )
Change subject: IMPALA-13912: Use SHARED_CLUSTER_ARGS in more custom cluster tests ...................................................................... Patch Set 9: (1 comment) I just remember, there is a consequence of not restarting cluster. Let say test A and B has same parameter, and A happen before B. Test A set custom query option to one of the default test client (self.client, self.hs2_client, etc). If test B not restarting minicluster, that custom query option from test A can leak to test B and affect its execution. This can unintentionally fail/crash test B. http://gerrit.cloudera.org:8080/#/c/22901/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22901/8//COMMIT_MSG@22 PS8, Line 22: : Experimentally, this results in ~150 fewer restarts, mostly coming from : restarts between tests. > Agree. Rebased and meanwhile added one more test which was failing on Jenki Done -- To view, visit http://gerrit.cloudera.org:8080/22901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c9115d4d47b9fe0bfd9dbda218aac2fb02dbd09 Gerrit-Change-Number: 22901 Gerrit-PatchSet: 9 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 22 May 2025 19:07:40 +0000 Gerrit-HasComments: Yes
