Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22901 )
Change subject: IMPALA-13912: Use SHARED_CLUSTER_ARGS in more custom cluster tests ...................................................................... Patch Set 11: (4 comments) > Also no visible time improvement on jenkins. I'm not sure if we should merge this now if there is no visible time improvement. Maybe stopping beeswax server (deprecate it) and stop checking its port availability in test framework can yield more time saving. This has conflict with https://gerrit.cloudera.org/c/22527, which is probably should be prioritized to merge first. I don't mind merging this if there is other benefit though. http://gerrit.cloudera.org:8080/#/c/22901/11/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22901/11/tests/common/custom_cluster_test_suite.py@161 PS11, Line 161: force_restart=False Question: In case things goes wrong, and we want to revert to old behavior (always restart in-between custom cluster tests), is it sufficient to change this default value from False to True? http://gerrit.cloudera.org:8080/#/c/22901/11/tests/common/custom_cluster_test_suite.py@369 PS11, Line 369: super(CustomClusterTestSuite, cls).setup_class() This line will reset all test clients, regardless of reusing existing cluster or not (please see ImpalaTestSuite.setup_class() to double check). Is this redundant/time consuming in case of cluster reuse, or not? Current code is probably good though, because it ensure that all tests clients are fresh on each test run. http://gerrit.cloudera.org:8080/#/c/22901/11/tests/common/custom_cluster_test_suite.py@592 PS11, Line 592: LOG.info("Starting cluster with command: %s" % cmd_str) Log this only if not reusing existing cluster. http://gerrit.cloudera.org:8080/#/c/22901/11/tests/common/custom_cluster_test_suite.py@599 PS11, Line 599: LOG.info("Reusing existing cluster...") Log the cmd_str that is being reused. -- To view, visit http://gerrit.cloudera.org:8080/22901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c9115d4d47b9fe0bfd9dbda218aac2fb02dbd09 Gerrit-Change-Number: 22901 Gerrit-PatchSet: 11 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 02 Jun 2025 02:35:49 +0000 Gerrit-HasComments: Yes
