Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22901 )
Change subject: IMPALA-13912: Use SHARED_CLUSTER_ARGS in more custom cluster tests ...................................................................... Patch Set 12: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/22901/11/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22901/11/tests/common/custom_cluster_test_suite.py@161 PS11, Line 161: force_restart=False > Question: In case things goes wrong, and we want to revert to old behavior Answered at https://gerrit.cloudera.org/c/22901/11..12#163 http://gerrit.cloudera.org:8080/#/c/22901/11/tests/common/custom_cluster_test_suite.py@163 PS11, Line 163: method's func_dict""" > I can be done rather at L348. I thought it's better to keep the logic there Ack http://gerrit.cloudera.org:8080/#/c/22901/11/tests/common/custom_cluster_test_suite.py@599 PS11, Line 599: cls.cluster = ImpalaCluster.get_e2e_tes > ack Done -- To view, visit http://gerrit.cloudera.org:8080/22901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c9115d4d47b9fe0bfd9dbda218aac2fb02dbd09 Gerrit-Change-Number: 22901 Gerrit-PatchSet: 12 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 02 Jun 2025 15:35:18 +0000 Gerrit-HasComments: Yes
