Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22974 )
Change subject: IMPALA-14110: Avoid decoding values for counting columns ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22974/1/testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-from-clause.test File testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-from-clause.test: http://gerrit.cloudera.org:8080/#/c/22974/1/testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-from-clause.test@288 PS1, Line 288: # Similar as above but there is a where clause on a non-array field. Not necessarily in this commit, but it could be useful to add a test dimension for late materialization in https://github.com/apache/impala/blob/master/tests/query_test/test_nested_types.py http://gerrit.cloudera.org:8080/#/c/22974/1/testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-from-clause.test@291 PS1, Line 291: select id from complextypes_arrays t, unnest(t.arr1) where id = 7; I am trying to understand what this specific query does - it only returns id, but repeats it for each row depending on the length of arr1, which means that arr1 we don't need the actual value, only some placeholder for the value, right? I am wondering if this was also reproducible before IMPALA-3841, as skipping already existed before lazy materialization to implement page filtering. My guess is that this is an old bug, just there wasn't any test for page filtering + complex types. -- To view, visit http://gerrit.cloudera.org:8080/22974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia707335c50cc0653097f375aae3f10609e0eb091 Gerrit-Change-Number: 22974 Gerrit-PatchSet: 1 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 03 Jun 2025 06:44:55 +0000 Gerrit-HasComments: Yes
