Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/22974 )
Change subject: IMPALA-14110: Avoid decoding values for counting columns ...................................................................... Patch Set 3: (3 comments) > Patch Set 1: Code-Review+1 > > (2 comments) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/22974/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22974/1//COMMIT_MSG@18 PS1, Line 18: Passed TestZippingUnnest in exhaustive mode. : > nit: Passed TestZippingUnnest in exhaustive mode. Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/22974/1/testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-from-clause.test File testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-from-clause.test: http://gerrit.cloudera.org:8080/#/c/22974/1/testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-from-clause.test@288 PS1, Line 288: # Similar as above but there is a where clause on a non-array field. > Not necessarily in this commit, but it could be useful to add a test dimens Sure. Thanks! I think we can do it later. http://gerrit.cloudera.org:8080/#/c/22974/1/testdata/workloads/functional-query/queries/QueryTest/zipping-unnest-in-from-clause.test@291 PS1, Line 291: select id from complextypes_arrays t, unnest(t.arr1) where id = 7; > I am trying to understand what this specific query does - it only returns i I agree with you about what this query does. I also agree that this is an old bug that affects page filtering. Added a test case for that. -- To view, visit http://gerrit.cloudera.org:8080/22974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia707335c50cc0653097f375aae3f10609e0eb091 Gerrit-Change-Number: 22974 Gerrit-PatchSet: 3 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Tue, 03 Jun 2025 11:44:50 +0000 Gerrit-HasComments: Yes
