Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22873 )
Change subject: IMPALA-14014: Fix COMPUTE STATS with TABLESAMPLE clause ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/22873/6/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/22873/6/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@830 PS6, Line 830: Map<Long, List<FileDescriptor>> sample = feFsTable.getFilesSample( : samplePerc, minSampleBytes, sampleSeed); > Yes, in case of COMPUTE STATS, we are doing it twice, first here, then in t You are right, let's not mix the fix with a non-trivial improvement. http://gerrit.cloudera.org:8080/#/c/22873/6/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/22873/6/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@364 PS6, Line 364: // We don't sample delete files (for correctness), let's add all of them to : // the merged result. > Great observation! I extended the cardinality estimation logic in IcebergDe Thanks! http://gerrit.cloudera.org:8080/#/c/22873/8/testdata/workloads/functional-planner/queries/PlannerTest/tablesample.test File testdata/workloads/functional-planner/queries/PlannerTest/tablesample.test: http://gerrit.cloudera.org:8080/#/c/22873/8/testdata/workloads/functional-planner/queries/PlannerTest/tablesample.test@414 PS8, Line 414: cardinality=6 Thanks for adding comments to the test! Shouldn't this cardinality be 3+2=5? Is the cardinality checked in this test? -- To view, visit http://gerrit.cloudera.org:8080/22873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie59d5fc1374ab69209a74f2488bcb9a7d510b782 Gerrit-Change-Number: 22873 Gerrit-PatchSet: 8 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 03 Jun 2025 11:52:15 +0000 Gerrit-HasComments: Yes
