Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22873 )
Change subject: IMPALA-14014: Fix COMPUTE STATS with TABLESAMPLE clause ...................................................................... Patch Set 9: (1 comment) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/22873/8/testdata/workloads/functional-planner/queries/PlannerTest/tablesample.test File testdata/workloads/functional-planner/queries/PlannerTest/tablesample.test: http://gerrit.cloudera.org:8080/#/c/22873/8/testdata/workloads/functional-planner/queries/PlannerTest/tablesample.test@414 PS8, Line 414: cardinality=5 > Thanks for adding comments to the test! Good catch, turned out this planner test did not check the cardinalities. -- To view, visit http://gerrit.cloudera.org:8080/22873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie59d5fc1374ab69209a74f2488bcb9a7d510b782 Gerrit-Change-Number: 22873 Gerrit-PatchSet: 9 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 03 Jun 2025 12:21:40 +0000 Gerrit-HasComments: Yes
