Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23012 )
Change subject: IMPALA-9874: Skip IO for late materialized columns ...................................................................... Patch Set 4: (5 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23012/4/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/23012/4/be/src/exec/parquet/hdfs-parquet-scanner.cc@1759 PS4, Line 1759: PartitionReaders(*col_reader->children(), can_eval_dict_filters, are_filter_readers); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23012/4/tests/query_test/test_parquet_late_materialization.py File tests/query_test/test_parquet_late_materialization.py: http://gerrit.cloudera.org:8080/#/c/23012/4/tests/query_test/test_parquet_late_materialization.py@49 PS4, Line 49: \ flake8: W605 invalid escape sequence '\(' http://gerrit.cloudera.org:8080/#/c/23012/4/tests/query_test/test_parquet_late_materialization.py@49 PS4, Line 49: \ flake8: W605 invalid escape sequence '\d' http://gerrit.cloudera.org:8080/#/c/23012/4/tests/query_test/test_parquet_late_materialization.py@49 PS4, Line 49: \ flake8: W605 invalid escape sequence '\)' http://gerrit.cloudera.org:8080/#/c/23012/4/tests/query_test/test_parquet_late_materialization.py@55 PS4, Line 55: def get_total_column_size(parquet_file_name, expected_num_row_groups, column_name): flake8: E303 too many blank lines (3) -- To view, visit http://gerrit.cloudera.org:8080/23012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a052b028220517503e634e3f916d1fbd60eb65d Gerrit-Change-Number: 23012 Gerrit-PatchSet: 4 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 12 Jun 2025 06:51:48 +0000 Gerrit-HasComments: Yes
