Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/23012 )
Change subject: IMPALA-9874: Skip IO for late materialized columns ...................................................................... Patch Set 6: (3 comments) > Patch Set 5: > > (3 comments) > > looks good in general, will make another pass on the c++ part Thank you very much! http://gerrit.cloudera.org:8080/#/c/23012/5/tests/query_test/test_parquet_late_materialization.py File tests/query_test/test_parquet_late_materialization.py: http://gerrit.cloudera.org:8080/#/c/23012/5/tests/query_test/test_parquet_late_materialization.py@67 PS5, Line 67: else > wow, I didn't know before this that for-else loops exist in python Thanks! http://gerrit.cloudera.org:8080/#/c/23012/5/tests/query_test/test_parquet_late_materialization.py@79 PS5, Line 79: client.exe > why is hs2_client used specifically? .client should also have the profile Thanks! Changed to using self.client . http://gerrit.cloudera.org:8080/#/c/23012/5/tests/query_test/test_parquet_late_materialization.py@81 PS5, Line 81: "parquet_dictionary_filtering": False, : "parquet_read_statistics": False, > Can't dictionary filtering also lead to skipping IO instead of lazy materia Thanks! Added the query option. -- To view, visit http://gerrit.cloudera.org:8080/23012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a052b028220517503e634e3f916d1fbd60eb65d Gerrit-Change-Number: 23012 Gerrit-PatchSet: 6 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Tue, 17 Jun 2025 08:02:48 +0000 Gerrit-HasComments: Yes
