Anonymous Coward (816) has posted comments on this change. ( http://gerrit.cloudera.org:8080/22967 )
Change subject: IMPALA-14115: Calcite planner: Added top-n analytic PlanNode optimization. ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22967/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java: http://gerrit.cloudera.org:8080/#/c/22967/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@125 PS4, Line 125: public NodeWithExprs getPlanNode(ParentPlanRelContext context) throws ImpalaException { I have an immature idea, if we use calcite rule PROJECT_TO_LOGICAL_PROJECT_AND_WINDOW, https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/rel/rules/ProjectToWindowRule.java, maybe can simplify the logic of Implement analytic functions? in this way, maybe we can easily implement rule for IMPALA-14115. and I think use this methods, we can reduce the difference between calcite and then do not use AnalyticPlanner in calcite fe.(maybe) -- To view, visit http://gerrit.cloudera.org:8080/22967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5697a65a16ee7902ac492ed20168ac66e1d01a91 Gerrit-Change-Number: 22967 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 17 Jun 2025 12:28:10 +0000 Gerrit-HasComments: Yes
