Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22967 )
Change subject: IMPALA-14115: Calcite planner: Added top-n analytic PlanNode optimization. ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22967/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java: http://gerrit.cloudera.org:8080/#/c/22967/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@125 PS4, Line 125: public NodeWithExprs getPlanNode(ParentPlanRelContext context) throws ImpalaException { > I have an immature idea, if we use calcite rule PROJECT_TO_LOGICAL_PROJECT_ Yeah, this is actually a really good idea. But full disclosure: I actually did stumble upon this after I had developed shoving it into a Project instead of a Window. But I hit a Calcite bug while doing this. Since I already had a fully developed version using Project, I decided to stick with it rather than converting this to a Window RelNode and fixing (or working around) the Calcite bug. I can't remember what the bug was now, so I'm not sure if it is fixed. But this is one of those ideas that I have in the back of my mind. Unfortunately, it's hard for me personally to justify working on this when we're close but still not at the point of having Calcite used as a general purpose compiler. There are more important things for me to work on. But...I do welcome others to join! If you would be able to change this, I would happily review it! -- To view, visit http://gerrit.cloudera.org:8080/22967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5697a65a16ee7902ac492ed20168ac66e1d01a91 Gerrit-Change-Number: 22967 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 17 Jun 2025 13:26:20 +0000 Gerrit-HasComments: Yes
