Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23042 )
Change subject: IMPALA-12337: Implement delete orphan files for Iceberg table ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/23042/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23042/5//COMMIT_MSG@21 PS5, Line 21: Any unmatched URI from FileSystem API : listing that has modification time less than 'olderThanTimestamp' : parameter will then be removed via Iceberg FileIO API of given Iceberg : table. Is there any limitation or warning that should be documented in connection with this behavior? http://gerrit.cloudera.org:8080/#/c/23042/5//COMMIT_MSG@26 PS5, Line 26: happen nit: happens http://gerrit.cloudera.org:8080/#/c/23042/5//COMMIT_MSG@31 PS5, Line 31: Note that after remove_orphan_files is executed, a new metadata.json is : created with the same snapshot id, but with a new "last-updated-ms". Could you please mention whether this is coming from Iceberg or Impala? http://gerrit.cloudera.org:8080/#/c/23042/3/fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteRemoveOrphanFilesStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteRemoveOrphanFilesStmt.java: http://gerrit.cloudera.org:8080/#/c/23042/3/fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteRemoveOrphanFilesStmt.java@36 PS3, Line 36: <parameter> > Done Sorry for the confusion. I meant simply listing using '-' without html formatting. http://gerrit.cloudera.org:8080/#/c/23042/5/testdata/workloads/functional-query/queries/QueryTest/iceberg-remove-orphan-negative.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-remove-orphan-negative.test: http://gerrit.cloudera.org:8080/#/c/23042/5/testdata/workloads/functional-query/queries/QueryTest/iceberg-remove-orphan-negative.test@3 PS5, Line 3: # EXECUTE REMOVE_ORPHAN_FILES must have a single timestamp expression / literal. : ALTER TABLE functional_parquet.iceberg_partitioned EXECUTE REMOVE_ORPHAN_FILES(); : ---- CATCH : EXECUTE REMOVE_ORPHAN_FILES(<expression>): must have one parameter : ==== : ---- QUERY This is already tested in the AnalyzeDDLTest. Is there any need to add an E2E test? -- To view, visit http://gerrit.cloudera.org:8080/23042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5979cdf15048d5a2c4784918533f65f32e888de0 Gerrit-Change-Number: 23042 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 19 Jun 2025 09:39:56 +0000 Gerrit-HasComments: Yes
