Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23042 )
Change subject: IMPALA-12337: Implement delete orphan files for Iceberg table ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/23042/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23042/5//COMMIT_MSG@21 PS5, Line 21: Any unmatched URI from FileSystem API : listing that has modification time less than 'olderThanTimestamp' : parameter will then be removed via Iceberg FileIO API of given Iceberg : table. > Is there any limitation or warning that should be documented in connection Added warnings about this query. http://gerrit.cloudera.org:8080/#/c/23042/5//COMMIT_MSG@26 PS5, Line 26: e by a > nit: happens Done http://gerrit.cloudera.org:8080/#/c/23042/5//COMMIT_MSG@31 PS5, Line 31: to execute the Iceberg API planFiles and FileIO API for deletion. : > Could you please mention whether this is coming from Iceberg or Impala? I think this happens from iceTxn.commitTransaction() calls at CatalogOpExecutor.alterIcebergTable(). http://gerrit.cloudera.org:8080/#/c/23042/5/testdata/workloads/functional-query/queries/QueryTest/iceberg-remove-orphan-negative.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-remove-orphan-negative.test: http://gerrit.cloudera.org:8080/#/c/23042/5/testdata/workloads/functional-query/queries/QueryTest/iceberg-remove-orphan-negative.test@3 PS5, Line 3: : : : : : > This is already tested in the AnalyzeDDLTest. Is there any need to add an E Decide to drop it since AnalyzeDDLTest already cover everything. -- To view, visit http://gerrit.cloudera.org:8080/23042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5979cdf15048d5a2c4784918533f65f32e888de0 Gerrit-Change-Number: 23042 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 19 Jun 2025 14:39:13 +0000 Gerrit-HasComments: Yes
