Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23080 )
Change subject: IMPALA-13947: Test local catalog mode by default ...................................................................... Patch Set 2: (6 comments) Thanks for sorting out the required test changes! http://gerrit.cloudera.org:8080/#/c/23080/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/23080/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@4017 PS2, Line 4017: overwrite It's an existing issue but 'overwrite' is not used in String.format(). nit: maybe make the indention similar to other codes looks better. http://gerrit.cloudera.org:8080/#/c/23080/2/testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-impalad.test File testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-impalad.test: http://gerrit.cloudera.org:8080/#/c/23080/2/testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-impalad.test@14 PS2, Line 14: Kudu error: cannot complete before timeout Why does the error message change? http://gerrit.cloudera.org:8080/#/c/23080/2/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23080/2/tests/authorization/test_ranger.py@57 PS2, Line 57: IMPALAD_ARGS nit: we hope new tests are not using this. Maybe rename it to LEGACY_CATALOG_IMPALAD_ARGS and rename LOCAL_CATALOG_IMPALAD_ARGS to this name? http://gerrit.cloudera.org:8080/#/c/23080/2/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/23080/2/tests/common/impala_connection.py@1094 PS2, Line 1094: if not PROGRESS_LOG_RE.match(line)] Is this an existing issue not related to local-catalog mode? http://gerrit.cloudera.org:8080/#/c/23080/2/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/23080/2/tests/custom_cluster/test_query_live.py@178 PS2, Line 178: 'org.apache.impala.catalog' in str(insert_result) : assert 'SystemTable' in str(insert_result) Does the original code fail? http://gerrit.cloudera.org:8080/#/c/23080/2/tests/custom_cluster/test_services_rpc_errors.py File tests/custom_cluster/test_services_rpc_errors.py: http://gerrit.cloudera.org:8080/#/c/23080/2/tests/custom_cluster/test_services_rpc_errors.py@103 PS2, Line 103: -1 Does using 8 fail so we use -1 here? -- To view, visit http://gerrit.cloudera.org:8080/23080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie303e294972d12b98f8354bf6bbc6d0cb920060f Gerrit-Change-Number: 23080 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 25 Jun 2025 06:35:50 +0000 Gerrit-HasComments: Yes
