Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23080 )

Change subject: IMPALA-13947: Test local catalog mode by default
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/23080/2/testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-impalad.test
File 
testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-impalad.test:

http://gerrit.cloudera.org:8080/#/c/23080/2/testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-impalad.test@14
PS2, Line 14: Kudu error: cannot complete before timeout
> Why does the error message change?
Error message change because it is now loaded in Coordinator?

Error in query profile:
    Query Status: AnalysisException: Failed to load metadata for table: 
'functional_kudu.alltypes'
CAUSED BY: TableLoadingException: Error opening Kudu table 
'impala::functional_kudu.alltypes', Kudu error: cannot complete before timeout: 
KuduRpc(method=GetTableSchema, tablet=null, attempt=0, 
TimeoutTracker(timeout=1, elapsed=2), No traces)

Error in coordinator log:
I20250625 12:22:20.020714 670418 jni-util.cc:321] 
0b49e7bb4daa017d:dd195b9000000000] org.apache.impala.common.AnalysisException: 
Failed to load metadata for table: 'functional_kudu.alltypes'
        at 
org.apache.impala.analysis.Analyzer.resolveTableRef(Analyzer.java:1121)
        at org.apache.impala.analysis.FromClause.analyze(FromClause.java:87)
        at 
org.apache.impala.analysis.SelectStmt$SelectAnalyzer.analyze(SelectStmt.java:333)
        at 
org.apache.impala.analysis.SelectStmt$SelectAnalyzer.access$100(SelectStmt.java:285)
        at org.apache.impala.analysis.SelectStmt.analyze(SelectStmt.java:277)
        at 
org.apache.impala.analysis.AnalysisContext$AnalysisDriverImpl.analyze(AnalysisContext.java:576)
        at 
org.apache.impala.analysis.AnalysisContext.analyzeAndAuthorize(AnalysisContext.java:496)
        at 
org.apache.impala.service.Frontend.doCreateExecRequest(Frontend.java:2922)
        at 
org.apache.impala.service.Frontend.getTExecRequest(Frontend.java:2495)
        at 
org.apache.impala.service.Frontend.getTExecRequestWithFallback(Frontend.java:2370)
        at 
org.apache.impala.service.Frontend.createExecRequest(Frontend.java:2059)
        at 
org.apache.impala.service.JniFrontend.createExecRequest(JniFrontend.java:174)
Caused by: org.apache.impala.catalog.TableLoadingException: Error opening Kudu 
table 'impala::functional_kudu.alltypes', Kudu error: cannot complete before 
timeout: KuduRpc(method=GetTableSchema, tablet=null, attempt=0, 
TimeoutTracker(timeout=1, elapsed=2), No traces)
        at 
org.apache.impala.catalog.local.LocalKuduTable$TableParams.openTable(LocalKuduTable.java:268)
        at 
org.apache.impala.catalog.local.LocalKuduTable.loadFromKudu(LocalKuduTable.java:70)
        at org.apache.impala.catalog.local.LocalTable.load(LocalTable.java:129)
        at org.apache.impala.catalog.local.LocalTable.load(LocalTable.java:114)
        at org.apache.impala.catalog.local.LocalDb.getTable(LocalDb.java:148)
        at 
org.apache.impala.analysis.StmtMetadataLoader.getMissingTables(StmtMetadataLoader.java:323)
        at 
org.apache.impala.analysis.StmtMetadataLoader.loadTables(StmtMetadataLoader.java:176)
        at 
org.apache.impala.analysis.StmtMetadataLoader.loadTables(StmtMetadataLoader.java:145)
        at 
org.apache.impala.service.Frontend.doCreateExecRequest(Frontend.java:2897)
        ... 4 more
I20250625 12:22:20.020759 670418 status.cc:129] 
0b49e7bb4daa017d:dd195b9000000000] AnalysisException: Failed to load metadata 
for table: 'functional_kudu.alltypes'
CAUSED BY: TableLoadingException: Error opening Kudu table 
'impala::functional_kudu.alltypes', Kudu error: cannot complete before timeout: 
KuduRpc(method=GetTableSchema, tablet=null, attempt=0, 
TimeoutTracker(timeout=1, elapsed=2), No traces)
    @          0x31715c5  impala::Status::Status()
    @          0x43afb89  impala::JniUtil::GetJniExceptionMsg()
    @          0x40dd12a  impala::JniCall::Call<>()
    @          0x40bb9e9  impala::Frontend::GetExecRequest()
    @          0x3e7b4f9  impala::QueryDriver::DoFrontendPlanning()
    @          0x3e7b6f5  impala::QueryDriver::RunFrontendPlanner()
    @          0x419d76f  impala::ImpalaServer::ExecuteInternal()
    @          0x419e3c1  impala::ImpalaServer::Execute()
    @          0x412cc0d  impala::ImpalaServer::ExecuteStatementCommon()
    @          0x412dff3  impala::ImpalaServer::ExecuteStatement()
    @          0x421a7af  
apache::hive::service::cli::thrift::TCLIServiceProcessorT<>::process_ExecuteStatement()
    @          0x425623f  
apache::hive::service::cli::thrift::TCLIServiceProcessorT<>::dispatchCall()
    @          0x42567e4  
impala::ImpalaHiveServer2ServiceProcessorT<>::dispatchCall()
    @          0x30753e1  apache::thrift::TDispatchProcessor::process()
    @          0x3d37acd  
apache::thrift::server::TAcceptQueueServer::Task::run()
    @          0x3d4f38f  impala::ThriftThread::RunRunnable()
    @          0x3d503c6  
boost::detail::function::void_function_obj_invoker0<>::invoke()
    @          0x448dd84  impala::Thread::SuperviseThread()
    @          0x448e889  boost::detail::thread_data<>::run()
    @          0x4607b07  thread_proxy
    @     0x7f13f2ec4609  start_thread
    @     0x7f13f0ede133  clone
    @              (nil)  (unknown)


http://gerrit.cloudera.org:8080/#/c/23080/2/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:

http://gerrit.cloudera.org:8080/#/c/23080/2/tests/authorization/test_ranger.py@57
PS2, Line 57: LEGACY_CATAL
> nit: we hope new tests are not using this. Maybe rename it to LEGACY_CATALO
Done


http://gerrit.cloudera.org:8080/#/c/23080/2/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/23080/2/tests/common/impala_connection.py@1094
PS2, Line 1094:              if not PROGRESS_LOG_RE.match(line)]
> Is this an existing issue not related to local-catalog mode?
Correct. This is to match ImpylaHS2Connection.get_log().
I might have tinker with changing test client in few failed test before, but 
ended up resolving it other way.
Regardless, this is a safe change.


http://gerrit.cloudera.org:8080/#/c/23080/2/tests/custom_cluster/test_query_live.py
File tests/custom_cluster/test_query_live.py:

http://gerrit.cloudera.org:8080/#/c/23080/2/tests/custom_cluster/test_query_live.py@178
PS2, Line 178:         'org.apache.impala.catalog' in str(insert_result)
             :     assert 'SystemTable' in str(insert_result)
> Does the original code fail?
I split it this way to catch both apache.impala.catalog.local.LocalSystemTable 
and apache.impala.catalog.SystemTable.


http://gerrit.cloudera.org:8080/#/c/23080/2/tests/custom_cluster/test_services_rpc_errors.py
File tests/custom_cluster/test_services_rpc_errors.py:

http://gerrit.cloudera.org:8080/#/c/23080/2/tests/custom_cluster/test_services_rpc_errors.py@103
PS2, Line 103: -1
> Does using 8 fail so we use -1 here?
-1 means at least 1 match expected.
The new code include query id to search, so it is more precise. This now ignore 
log lines from unique_database CREATE and DROP.



--
To view, visit http://gerrit.cloudera.org:8080/23080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie303e294972d12b98f8354bf6bbc6d0cb920060f
Gerrit-Change-Number: 23080
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Wed, 25 Jun 2025 19:34:37 +0000
Gerrit-HasComments: Yes

Reply via email to