Hello Vuk Ercegovac, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10620
to review the following change.
Change subject: IMPALA-7105. Ensure fe tests pass when running standalone
......................................................................
IMPALA-7105. Ensure fe tests pass when running standalone
CatalogTest and HdfsStorageDescriptorTest would fail when run
individually because they relied on various initialization that only
occurs when FeSupport is loaded. These tests weren't explicitly loading
FeSupport, but instead relying on earlier tests in 'mvn test' to do so.
Tested that, with this change, I'm able to run these tests in Eclipse
and they pass. I also tested 'mvn test -DreuseForks=false' and verified
that all tests now pass in this mode.
Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555
Reviewed-on: http://gerrit.cloudera.org:8080/10570
Reviewed-by: Vuk Ercegovac <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M fe/src/main/java/org/apache/impala/service/FeSupport.java
M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
M fe/src/test/java/org/apache/impala/catalog/HdfsStorageDescriptorTest.java
M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
4 files changed, 14 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/10620/1
--
To view, visit http://gerrit.cloudera.org:8080/10620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555
Gerrit-Change-Number: 10620
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
