Hello Lars Volker, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10616
to review the following change.
Change subject: Guard S3 access check with variable
......................................................................
Guard S3 access check with variable
We've recently seen automated build failures where multiple inclusions
of impala-config.sh led to the S3 access check being performed multiple
times. This would trigger rate limiting on S3's side, which then caused
the jobs to fail.
This change adds a guard to only perform the check once, even when
including impala-config.sh multiple times.
To test this I included impala-config.sh multiple times on my local
shell and observed that the check was only performed once.
Change-Id: I1df16b2d037afafb7748f52b64732f680883f16c
Reviewed-on: http://gerrit.cloudera.org:8080/10607
Reviewed-by: Lars Volker <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M bin/impala-config.sh
1 file changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/10616/1
--
To view, visit http://gerrit.cloudera.org:8080/10616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1df16b2d037afafb7748f52b64732f680883f16c
Gerrit-Change-Number: 10616
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
