Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23118 )
Change subject: IMPALA-14017: Add Ranger tests to Iceberg REST Catalog ...................................................................... Patch Set 1: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23118/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23118/1/tests/authorization/test_ranger.py@3244 PS1, Line 3244: class TestRangerIcebergRestCatalog(TestRanger): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/23118/1/tests/authorization/test_ranger.py@3294 PS1, Line 3294: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23118/1/tests/authorization/test_ranger.py@3298 PS1, Line 3298: ) flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23118/1/tests/authorization/test_ranger.py@3319 PS1, Line 3319: flake8: W292 no newline at end of file http://gerrit.cloudera.org:8080/#/c/23118/1/tests/common/iceberg_rest_server.py File tests/common/iceberg_rest_server.py: http://gerrit.cloudera.org:8080/#/c/23118/1/tests/common/iceberg_rest_server.py@30 PS1, Line 30: class IcebergRestServer(object): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/23118/1/tests/common/iceberg_rest_server.py@71 PS1, Line 71: flake8: W292 no newline at end of file -- To view, visit http://gerrit.cloudera.org:8080/23118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d506e04537c5ca878ab9cf58792bc8a6b560c3 Gerrit-Change-Number: 23118 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 03 Jul 2025 14:08:00 +0000 Gerrit-HasComments: Yes
