Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23118 )
Change subject: IMPALA-14017: Add Ranger tests to Iceberg REST Catalog ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23118/2/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23118/2/tests/authorization/test_ranger.py@3306 PS2, Line 3306: """Run iceberg-rest-catalog.test with all the required privileges.""" Can you add a negative test as well? http://gerrit.cloudera.org:8080/#/c/23118/2/tests/common/iceberg_rest_server.py File tests/common/iceberg_rest_server.py: http://gerrit.cloudera.org:8080/#/c/23118/2/tests/common/iceberg_rest_server.py@18 PS2, Line 18: from __future__ import absolute_import, division, print_function This import was added after PS1, might it be unused? -- To view, visit http://gerrit.cloudera.org:8080/23118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d506e04537c5ca878ab9cf58792bc8a6b560c3 Gerrit-Change-Number: 23118 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 07 Jul 2025 08:41:31 +0000 Gerrit-HasComments: Yes
