Hello Vuk Ercegovac,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/10627

to review the following change.


Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog
......................................................................

IMPALA-7135. Skeleton implementation of LocalCatalog

This adds some of the high level classes for implementing the local
catalog:

- LocalCatalog is the top level implementation. The plan is to
  instantiate this once per query, so that no thread safety is required.

- It loads metadata from a MetaProvider interface. The current
  implementation fetches directly from HMS and provides no caching. A
  future subtask will add a CachingMetaProvider implementation.
  Separating out caching will make it easier to experiment with
  different policies or storage mechanisms.

- It instantiates LocalDb and LocalTable objects to implement FeDb and
  FeTable. These are mostly stubbed out except for the most basic
  functionality. Functionality will be filled in incrementally in
  further patches.

Since it's not yet possible to hook this up to most of the existing
tests, a very simple new unit test is included to cover the bits of
functionality that are not stubbed out. I didn't concentrate on too much
test coverage here, since once we've implemented more functionality we
can switch over all of the existing tests to get coverage of the new
implementation.

Change-Id: Iab653371188b21c72f50ee1ec4e94950aa6fb9ee
---
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
A fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java
A fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
A fe/src/main/java/org/apache/impala/catalog/local/LocalCatalogException.java
A fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java
A fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
A fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java
A fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
8 files changed, 765 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/10627/1
--
To view, visit http://gerrit.cloudera.org:8080/10627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab653371188b21c72f50ee1ec4e94950aa6fb9ee
Gerrit-Change-Number: 10627
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>

Reply via email to