Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala ...................................................................... Patch Set 49: (2 comments) http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java: http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@29 PS49, Line 29: public class ValidReaderWriteIdList implements ValidWriteIdList { If these codes are never used and just used for compilation, we can make these fake classes that have no fields and all methods return nulls. http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java File fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java: http://gerrit.cloudera.org:8080/#/c/21760/49/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java@798 PS49, Line 798: return ""; Instead of returning an empty string and add lots of codes for the missing catName, can we try patching hive_metastore.thrift to add the optional catName field? We have some patches for Apache Hive 3 under testdata/cluster/hive, used by testdata/bin/patch_hive.sh. We can add one for Apache Hive 2 in the same way. -- To view, visit http://gerrit.cloudera.org:8080/21760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c Gerrit-Change-Number: 21760 Gerrit-PatchSet: 49 Gerrit-Owner: ttttttz <2433038...@qq.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Reviewer: ttttttz <2433038...@qq.com> Gerrit-Comment-Date: Sun, 06 Jul 2025 09:34:02 +0000 Gerrit-HasComments: Yes
