Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala ...................................................................... Patch Set 51: (10 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java: http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@160 PS51, Line 160: org.apache.thrift.TFieldRequirementType.REQUIRED, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@165 PS51, Line 165: org.apache.thrift.TFieldRequirementType.REQUIRED, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@170 PS51, Line 170: org.apache.thrift.TFieldRequirementType.REQUIRED, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@177 PS51, Line 177: org.apache.thrift.TFieldRequirementType.OPTIONAL, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766 PS51, Line 766: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@774 PS51, Line 774: } else { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@782 PS51, Line 782: } else { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800 PS51, Line 800: } else { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@808 PS51, Line 808: } else { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/51/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@816 PS51, Line 816: } else { line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/21760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c Gerrit-Change-Number: 21760 Gerrit-PatchSet: 51 Gerrit-Owner: ttttttz <2433038...@qq.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Reviewer: ttttttz <2433038...@qq.com> Gerrit-Comment-Date: Sun, 06 Jul 2025 12:34:45 +0000 Gerrit-HasComments: Yes
