Steve Carlin has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/23124 )
Change subject: IMPALA-14126: Calcite planner: Fixed issues with character types ...................................................................... IMPALA-14126: Calcite planner: Fixed issues with character types There were a couple of issues with character types (char, varchar, string) that needed fixing: - count(varchar()) was not being cast correctly to string. The fix for this is in CoerceNodes.areSqlTypesEqual which now makes sure varchar is not the same sql type as string. - case did not have a proper signature for varchar. There is a weird quirk in function resolving for case where it always returns the "case(boolean)" signature. This seems like a more intrusive change to fix, so the Calcite planner now uses the same boolean signature and changes the return type in the Expr object, as done by the original planner. - varchar to char casts are now handled correctly Change-Id: I82d25bfec45cc287e7a510c23a99476d7c819e8f --- M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/FunctionResolver.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java M testdata/workloads/functional-query/queries/QueryTest/calcite.test 6 files changed, 163 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/23124/7 -- To view, visit http://gerrit.cloudera.org:8080/23124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I82d25bfec45cc287e7a510c23a99476d7c819e8f Gerrit-Change-Number: 23124 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]>
