Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23135 )
Change subject: IMPALA-14126: Calcite planner: Fixed issues with character types ...................................................................... Patch Set 1: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23135/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/23135/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@642 PS1, Line 642: // if both precisions are not -1, they are both varchars line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23135/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java: http://gerrit.cloudera.org:8080/#/c/23135/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@227 PS1, Line 227: RelDataType retType = ImpalaTypeConverter.createRelDataType(factory, impalaReturnType); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I157d7bf4402031dd9874291963596f25f4729d7d Gerrit-Change-Number: 23135 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 07 Jul 2025 03:30:06 +0000 Gerrit-HasComments: Yes
