Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23140 )
Change subject: IMPALA-14207: Hook log4j to Glog in AdmissionD ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23140/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23140/1//COMMIT_MSG@17 PS1, Line 17: Executors/CatalogD does not call GlogAppender.Install twice. > It is first added by IMPALA-12345 I was mostly observing that it appears safe to reinitialize BackendConfig.create, but you don't want to for GlogAppender.Install. And that's why it looks different than in JniCatalog and JniFrontend. -- To view, visit http://gerrit.cloudera.org:8080/23140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie28ec017f70c79d6ffdc56daa5aaeb9efcb8bb79 Gerrit-Change-Number: 23140 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 07 Jul 2025 22:14:46 +0000 Gerrit-HasComments: Yes
