Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23140 )
Change subject: IMPALA-14207: Hook log4j to Glog in AdmissionD ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/23140/3/be/src/scheduling/request-pool-service.cc File be/src/scheduling/request-pool-service.cc: http://gerrit.cloudera.org:8080/#/c/23140/3/be/src/scheduling/request-pool-service.cc@155 PS3, Line 155: jni_env->CallObjectMethod(jni_request_pool_service_, reinstall_glog_appender_id); We could avoid the extra function call if you passed is_admissiond as an argument to the constructor. That would also allow skipping the redundant BackendConfig init. -- To view, visit http://gerrit.cloudera.org:8080/23140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie28ec017f70c79d6ffdc56daa5aaeb9efcb8bb79 Gerrit-Change-Number: 23140 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 08 Jul 2025 22:07:09 +0000 Gerrit-HasComments: Yes
