Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23075 )
Change subject: IMPALA-13892: Add support for printing STRUCTs ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/23075/8/be/src/util/debug-util.cc File be/src/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/23075/8/be/src/util/debug-util.cc@219 PS8, Line 219: DCHECK_LE(field_idx, struct_type.field_names.size()); > This should be DCHECK_LT. Even DCHECK_LE fails with "select nested_struct f My logic is wrong for arrays and maps under structs for ORC Full ACID. Parquet seems to work fine (but isn't Full ACID). nested_struct.a: Parquet: [5 0] -> Works ORC Full ACID: [5 5 0] -> Works nested_struct.b: Parquet: [5 1] -> Works ORC Full ACID: [5 5] -> Doesn't work (missing last index?) nested_struct.c: Parquet: [5 2] -> Works ORC Full ACID: [5 5 2] - Works nested_struct.c.d: Parquet: [5 2 0] -> Works ORC Full ACID: [5 5 2] - Doesn't work (missing last index?) This will need more work to get the field names right. -- To view, visit http://gerrit.cloudera.org:8080/23075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9479754c2766a9dd6483ba065e26a4d3a22e7e9 Gerrit-Change-Number: 23075 Gerrit-PatchSet: 8 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 08 Jul 2025 06:23:13 +0000 Gerrit-HasComments: Yes
