Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23075 )
Change subject: IMPALA-13892: Add support for printing STRUCTs ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/23075/7/be/src/runtime/raw-value.cc File be/src/runtime/raw-value.cc: http://gerrit.cloudera.org:8080/#/c/23075/7/be/src/runtime/raw-value.cc@126 PS7, Line 126: *str = string(reinterpret_cast<const char*>(value), type.len); > Don't we need to escape invalid unicode characters, like on L521? This function is used in places that want the raw string without escaping, but obviously TYPE_FIXED_UDA_INTERMEDIATE can't be used outside of Impala so that doesn't apply. I'm going to remove the TYPE_FIXED_UDA_INTERMEDIATE case so it falls through to the other function. The cases in this switch are optimizations vs using the regular PrintValue and don't apply to TYPE_FIXED_UDA_INTERMEDIATE. -- To view, visit http://gerrit.cloudera.org:8080/23075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9479754c2766a9dd6483ba065e26a4d3a22e7e9 Gerrit-Change-Number: 23075 Gerrit-PatchSet: 7 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 11 Jul 2025 21:52:24 +0000 Gerrit-HasComments: Yes
