Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23140 )
Change subject: IMPALA-14207: Hook log4j to Glog in AdmissionD ...................................................................... Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23140/5/fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java File fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/23140/5/fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java@82 PS5, Line 82: GlogAppender.Install(TLogLevel.values()[cfg.impala_log_lvl], nit: I don't see a reason to wait until after RequestPoolService.getInstance to setup logging. And you could skip thriftBackendConfig deserialization and BackendConfig.create unless isAdmissiond, because those are handled elsewhere. It would make the initialization look more like JniFrontend. -- To view, visit http://gerrit.cloudera.org:8080/23140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie28ec017f70c79d6ffdc56daa5aaeb9efcb8bb79 Gerrit-Change-Number: 23140 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 08 Jul 2025 22:35:09 +0000 Gerrit-HasComments: Yes
