Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23140 )
Change subject: IMPALA-14207: Hook log4j to Glog in AdmissionD ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/23140/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23140/8//COMMIT_MSG@16 PS8, Line 16: Only AdmissionD will : initialize JniRequestPoolService with this parameter equals True nit. maybe rephrase as "Only AdmissionD sets this parameter to true when initializing JniRequestPoolService" http://gerrit.cloudera.org:8080/#/c/23140/8/fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java File fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/23140/8/fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java@68 PS8, Line 68: * @param sitePath path to the configuration file. We may want the desc for "@param isAdmissiond". Maybe saying something like "true if running in AdmissionD, enable log4j to Glog hookup" http://gerrit.cloudera.org:8080/#/c/23140/8/fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java@79 PS8, Line 79: LOG.info(JniUtil.getJavaVersion()); How about printing more context in the log here? Something like, "GlogAppender installed for AdmissionD, Java version: " -- To view, visit http://gerrit.cloudera.org:8080/23140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie28ec017f70c79d6ffdc56daa5aaeb9efcb8bb79 Gerrit-Change-Number: 23140 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 09 Jul 2025 16:53:13 +0000 Gerrit-HasComments: Yes
