Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23140 )
Change subject: IMPALA-14207: Hook log4j to Glog in AdmissionD ...................................................................... IMPALA-14207: Hook log4j to Glog in AdmissionD log4j logs does not shows up in dedicated AdmissionD service. This is because GlogAppender.Install is not called anywhere. It is called in constructor of JniCatalog.java and JniFrontend.java, but AdmissionD does not utilize either of them. AdmissionD has call path to JniRequestPoolService.java. This patch adds isAdmissiond parameter to JniRequestPoolService constructor to call GlogAppender.Install and hook up log4j to Glog. Only AdmissionD sets this parameter to true when initializing JniRequestPoolService. Note that this hook up only happen if fair_scheduler_allocation_path flag is not empty. Testing: Run few tests in TestAdmissionControllerWithACService and confirm log4j logs appears in admissiond.INFO Change-Id: Ie28ec017f70c79d6ffdc56daa5aaeb9efcb8bb79 Reviewed-on: http://gerrit.cloudera.org:8080/23140 Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Yida Wu <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/scheduling/admissiond-env.cc M be/src/scheduling/request-pool-service.cc M be/src/scheduling/request-pool-service.h M fe/src/main/java/org/apache/impala/util/JniRequestPoolService.java M fe/src/main/java/org/apache/impala/util/RequestPoolService.java 5 files changed, 23 insertions(+), 13 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Yida Wu: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/23140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie28ec017f70c79d6ffdc56daa5aaeb9efcb8bb79 Gerrit-Change-Number: 23140 Gerrit-PatchSet: 10 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
