Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23094 )
Change subject: IMPALA-12057: Track removed coordinators to reject queued queries early ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/23094/4/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/23094/4/be/src/scheduling/admission-controller.cc@2580 PS4, Line 2580: if (outcome == AdmissionOutcome::REJECTED) { > We should probably log AdmissionOutcome for transparency to explain why the Done http://gerrit.cloudera.org:8080/#/c/23094/4/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23094/4/tests/custom_cluster/test_admission_controller.py@2208 PS4, Line 2208: # Start the coordinator to avoid possible errors during teardown. > all_coords[0].start() seems unnecessary at the end? This was added to avoid unnecessary error messages, when the test checks impalad metrics during teardown. It doesn’t affect the test results. Added a comment. -- To view, visit http://gerrit.cloudera.org:8080/23094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e0f270299f8c20975d7895c17f4e2791c3360e0 Gerrit-Change-Number: 23094 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 09 Jul 2025 17:34:36 +0000 Gerrit-HasComments: Yes
