Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23094 )
Change subject: IMPALA-12057: Track removed coordinators to reject queued queries early ...................................................................... Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/23094/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23094/5//COMMIT_MSG@13 PS5, Line 13: resulting in unnecessary waiting until timeout. > The timeout is determined by either FLAGS_queue_wait_timeout_ms or the queu Ack http://gerrit.cloudera.org:8080/#/c/23094/5/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/23094/5/be/src/scheduling/admission-controller.cc@263 PS5, Line 263: FIX = "The coordinator no longer > Done Done http://gerrit.cloudera.org:8080/#/c/23094/5/be/src/scheduling/admission-controller.cc@2547 PS5, Line 2547: >local_stats().num_queue > Changed to allow FindGroupToAdmitOrReject to return false in this case. Done http://gerrit.cloudera.org:8080/#/c/23094/5/be/src/scheduling/cluster-membership-mgr-test.cc File be/src/scheduling/cluster-membership-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/23094/5/be/src/scheduling/cluster-membership-mgr-test.cc@329 PS5, Line 329: > Done Done http://gerrit.cloudera.org:8080/#/c/23094/5/be/src/scheduling/cluster-membership-mgr-test.cc@332 PS5, Line 332: ble(rng_); > Done Done http://gerrit.cloudera.org:8080/#/c/23094/7/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/23094/7/be/src/scheduling/cluster-membership-mgr.cc@195 PS7, Line 195: _addToRemovedCoordinators addToRemoved sounds conflicting to me. Perhaps MarkCoordinatorAsMissing is better? http://gerrit.cloudera.org:8080/#/c/23094/7/be/src/scheduling/cluster-membership-mgr.cc@221 PS7, Line 221: _addToRemovedCoordinators(state, be, *actual_be); Under intermittent network partition, is it possible that same coordinator that previously declared gone is coming back again with the same backend id? If that happens, they should be removed from state->removed_coordinators_map and state->removed_coordinators_order, right? -- To view, visit http://gerrit.cloudera.org:8080/23094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e0f270299f8c20975d7895c17f4e2791c3360e0 Gerrit-Change-Number: 23094 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 10 Jul 2025 16:12:31 +0000 Gerrit-HasComments: Yes
