Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10605 )
Change subject: IMPALA-7108: IllegalStateException hit during CardinalityCheckNode.<init> ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10605/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/10605/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@1082 PS2, Line 1082: * Check if the stmt returns a single row. This can happen > Should this be "returns at most one row"? Fixed the comment. I have similar comments in the tests but I didn't change them because the used queries do return a single row. -- To view, visit http://gerrit.cloudera.org:8080/10605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82a7a3fe26db3e12131c030c4ad055a9c4955407 Gerrit-Change-Number: 10605 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Jun 2018 09:09:18 +0000 Gerrit-HasComments: Yes
