Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10605 )
Change subject: IMPALA-7108: IllegalStateException hit during CardinalityCheckNode.<init> ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/10605/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/10605/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@1082 PS3, Line 1082: returns at most one r > I think this bit is still inaccurate. Changed to 'returns at most one row'. The name of the method is still inaccurate, but maybe it's okay with the rephrased comments. http://gerrit.cloudera.org:8080/#/c/10605/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@1100 PS3, Line 1100: returns at most one > Does this one need to be changed to be inline with 4. above as well? Right, thanks! -- To view, visit http://gerrit.cloudera.org:8080/10605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82a7a3fe26db3e12131c030c4ad055a9c4955407 Gerrit-Change-Number: 10605 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Jun 2018 09:55:00 +0000 Gerrit-HasComments: Yes
