Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 )
Change subject: IMPALA-2751: Matching quotes are not required in comments ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/10541/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10541/4//COMMIT_MSG@12 PS4, Line 12: The fix is to strip any SQL comments before sending to shlex since shlex : does not understand SQL comments and will raise an exception when it : sees : unmatched quotes regardless whether the quotes are in the comments or : not. Misaligned text. Can you clean it up? http://gerrit.cloudera.org:8080/#/c/10541/4/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/10541/4/tests/shell/test_shell_interactive.py@531 PS4, Line 531: ] I missed the reason for the revert. Are additional test cases needed? -- To view, visit http://gerrit.cloudera.org:8080/10541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2feae34026a7e63f3d31489f757f093a73ca5d2c Gerrit-Change-Number: 10541 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Thu, 07 Jun 2018 16:14:37 +0000 Gerrit-HasComments: Yes
