Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 )
Change subject: IMPALA-2751: Matching quotes are not required in comments ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/10541/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10541/4//COMMIT_MSG@12 PS4, Line 12: The fix is to strip any SQL comments before sending to shlex since shlex : does not understand SQL comments and will raise an exception when it : sees unmatched quotes regardless whether the quotes are in the comments or : not. : > Misaligned text. Can you clean it up? Done http://gerrit.cloudera.org:8080/#/c/10541/4/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/10541/4/tests/shell/test_shell_interactive.py@531 PS4, Line 531: ] > I missed the reason for the revert. Are additional test cases needed? It's the Python 2.6 and Python 2.7 different behaviors with regards to unicode. I think the best way is to have GVO that runs both CentOS 6 and Ubuntu 16.04. I believe this isn't the first time we ran into issues with Python 2.6 vs Python 2.7. I did run the whole shell tests on CentOS 6, though. Let me know what you think. -- To view, visit http://gerrit.cloudera.org:8080/10541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2feae34026a7e63f3d31489f757f093a73ca5d2c Gerrit-Change-Number: 10541 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Comment-Date: Thu, 07 Jun 2018 16:24:12 +0000 Gerrit-HasComments: Yes
