Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config ...................................................................... Patch Set 2: (2 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/23175/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23175/1//COMMIT_MSG@25 PS1, Line 25: > Is there any valid use case for setting these configs to "true"? As far as Yes, it is a big hammer to completely disable block location loading efficiently. We could make it more sophisticated, e.g.: global < scheme < authority But I don't think it's necessary to complicate the logic as there'll be only 1-3 storage systems configured at most, realistically, so it should be easy to configure them. I'll also create a follow-up doc Jira once this CR finalizes. http://gerrit.cloudera.org:8080/#/c/23175/1/bin/create-test-configuration.sh File bin/create-test-configuration.sh: http://gerrit.cloudera.org:8080/#/c/23175/1/bin/create-test-configuration.sh@138 PS1, Line 138: CORE_SITE_VARIANT=disable_block_locations $IMPALA_HOME/bin/generate_xml_config.py \ > Shouldn't we reset this env var for future safety? Or instead of exporting Good idea, I went with the latter. -- To view, visit http://gerrit.cloudera.org:8080/23175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867 Gerrit-Change-Number: 23175 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 16 Jul 2025 09:14:45 +0000 Gerrit-HasComments: Yes
