Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23175 )

Change subject: IMPALA-14138: Manually disable block location loading via 
Hadoop config
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23175/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23175/1//COMMIT_MSG@25
PS1, Line 25:
> Yes, it is a big hammer to completely disable block location loading effici
I agree we don't need to make it more sophisticated.

This is also true with schemes and authorities, if something is disabled with 
schemes we can't re-enable it through authorities (e.g. no block-location 
loading on HDFS except on 'mycluster'). So instead of saying the global config 
overrides the others, we could say something like if block-location loading is 
disabled by any of the switches, it cannot be re-enabled by another, i.e. the 
most restrictive setting prevails.



--
To view, visit http://gerrit.cloudera.org:8080/23175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867
Gerrit-Change-Number: 23175
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 16 Jul 2025 09:47:34 +0000
Gerrit-HasComments: Yes

Reply via email to