Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22924 )
Change subject: IMPALA-13237: [Patch 5] - Implement OpenTelemetry Traces for Select Queries Tracking ...................................................................... Patch Set 93: (3 comments) http://gerrit.cloudera.org:8080/#/c/22924/93/be/src/observe/span-manager.cc File be/src/observe/span-manager.cc: http://gerrit.cloudera.org:8080/#/c/22924/93/be/src/observe/span-manager.cc@155 PS93, Line 155: event event nit: event http://gerrit.cloudera.org:8080/#/c/22924/93/be/src/observe/span-manager.cc@299 PS93, Line 299: attrs.emplace(ATTR_NUM_ROWS_FETCHED_FROM_CACHE, : client_request_state_->num_rows_fetched_from_cache_counter()); This is the cached query results from the current query and doesn't survive beyond the query close. Not sure if the intention of this attribute is to capture this? For instance this is not the same as Hive's query result cache. Not sure if we want to capture this in the trace, as this could easily get confusing? http://gerrit.cloudera.org:8080/#/c/22924/93/be/src/observe/span-manager.cc@393 PS93, Line 393: auto a Use reference and avoid creating local copies. -- To view, visit http://gerrit.cloudera.org:8080/22924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie40b5cd33274df13f3005bf7a704299ebfff8a5b Gerrit-Change-Number: 22924 Gerrit-PatchSet: 93 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Mon, 11 Aug 2025 14:29:18 +0000 Gerrit-HasComments: Yes
