Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22924 )
Change subject: IMPALA-13237: [Patch 5] - Implement OpenTelemetry Traces for Select Queries Tracking ...................................................................... Patch Set 95: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22924/95/be/src/observe/span-manager.cc File be/src/observe/span-manager.cc: http://gerrit.cloudera.org:8080/#/c/22924/95/be/src/observe/span-manager.cc@388 PS95, Line 388: ATTR_ELAPSED_TIME, std::move(additional_attributes), trace::SpanKind::kInternal, root_); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22924/95/tests/custom_cluster/test_otel_trace.py File tests/custom_cluster/test_otel_trace.py: http://gerrit.cloudera.org:8080/#/c/22924/95/tests/custom_cluster/test_otel_trace.py@26 PS95, Line 26: from tests.util.query_profile_util import parse_db_user, parse_session_id, parse_sql, \ flake8: F401 'tests.util.query_profile_util.parse_num_rows_fetched_from_cache' imported but unused -- To view, visit http://gerrit.cloudera.org:8080/22924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie40b5cd33274df13f3005bf7a704299ebfff8a5b Gerrit-Change-Number: 22924 Gerrit-PatchSet: 95 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Aug 2025 19:32:41 +0000 Gerrit-HasComments: Yes
