Jason Fehr has uploaded a new patch set (#97) to the change originally created by gaurav singh. ( http://gerrit.cloudera.org:8080/22924 )
Change subject: IMPALA-13237: [Patch 5] - Implement OpenTelemetry Traces for Select Queries Tracking ...................................................................... IMPALA-13237: [Patch 5] - Implement OpenTelemetry Traces for Select Queries Tracking Adds representation of Impala select queries using OpenTelemetry traces. Each Impala query is represented as its own individual OpenTelemetry trace. The one exception is retried queries which will have an individual trace for each attempt. These traces consist of a root span and several child spans. Each child span has the root as its parent. No child span has another child span as its parent. Each child span represents one high-level query lifecycle stage. Each child span also has span attributes that further describe the state of the query. Child spans: 1. Init 2. Submitted 3. Planning 4. Admission Control 5. Query Execution 6. Close Each child span contains a mix of universal attributes (available on all spans) and query phase specific attributes. For example, the "ErrorMsg" attribute, present on all child spans, is the error message (if any) at the end of that particular query phase. One example of a child span specific attribute is "QueryType" on the Planning span. Since query type is first determined during query planning, the "QueryType" attribute is present on the Planning span and has a value of "QUERY" (since only selects are supported). Since queries can run for lengthy periods of time, the Init span communicates the beginning of a query along with global query attributes. For example, span attributes include query id, session id, sql, user, etc. Once the query has closed, the root span is closed. Testing accomplished with new custom cluster tests. Generated-by: Github Copilot (GPT-4.1, Claude Sonnet 3.7) Change-Id: Ie40b5cd33274df13f3005bf7a704299ebfff8a5b --- M be/CMakeLists.txt A be/src/observe/CMakeLists.txt A be/src/observe/otel-flags-trace.cc A be/src/observe/otel-flags.cc A be/src/observe/otel-instrument.h A be/src/observe/otel.cc A be/src/observe/otel.h A be/src/observe/span-manager.cc A be/src/observe/span-manager.h A be/src/observe/timed-span.cc A be/src/observe/timed-span.h M be/src/runtime/coordinator.cc M be/src/runtime/exec-env.cc M be/src/runtime/query-driver.cc M be/src/scheduling/admission-control-client.h M be/src/scheduling/local-admission-control-client.cc M be/src/scheduling/local-admission-control-client.h M be/src/scheduling/remote-admission-control-client.cc M be/src/scheduling/remote-admission-control-client.h M be/src/service/client-request-state.cc M be/src/service/client-request-state.h M be/src/service/impala-server.cc M bin/impala-config.sh M tests/common/custom_cluster_test_suite.py M tests/common/file_utils.py A tests/custom_cluster/test_otel_trace.py A tests/util/otel_trace.py A tests/util/query_profile_util.py 28 files changed, 2,821 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/22924/97 -- To view, visit http://gerrit.cloudera.org:8080/22924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie40b5cd33274df13f3005bf7a704299ebfff8a5b Gerrit-Change-Number: 22924 Gerrit-PatchSet: 97 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com>
